test: expand GitHub datasource E2E coverage - #797
Open
akkikumar72 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Expands end-to-end coverage for the GitHub datasource query/variable editors using deterministic mocked query responses, addressing the gap noted in #205.
Changes:
- Adds a new E2E test for the Variable Query Editor to validate Releases query serialization (
metricFindQuery) and rendered preview values. - Extends Query Editor E2E coverage with a Branches test validating filter serialization and rendered table output.
- Introduces additional mock responses to support the new E2E scenarios (variable refId and branches frame).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/VariableQueryEditor.spec.ts | New E2E test covering variable query (Releases) request serialization and preview rendering. |
| tests/QueryEditor.spec.ts | Adds E2E coverage for Branches query filter serialization and table rendering. |
| tests/mocks/github-response.ts | Adds deterministic mock responses for variable queries (metricFindQuery) and branches results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205